On Fri, Feb 03, 2017 at 10:22:42AM -0500, Brian Foster wrote: > > - return container_of(a, struct xfs_extent_busy, list)->agno - > > - container_of(b, struct xfs_extent_busy, list)->agno; > > + struct xfs_extent_busy *b1 = > > + container_of(l1, struct xfs_extent_busy, list); > > + struct xfs_extent_busy *b2 = > > + container_of(l2, struct xfs_extent_busy, list); > > + > > + return b1->agno - b2->agno || b1->bno - b2->bno; > > When will this ever return negative? Yes, this version is broken unfortunately, I'll fix it up. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html