On 2/1/17 4:19 PM, Richard Weinberger wrote: > Hi! > > On my armv7 box, current xfsprogs fail to build: > [TEST] CRC32 > In file included from crc32.c:37:0: > ../include/xfs.h:53:12: error: size of array ‘xfs_assert_largefile’ is too large neat ;) Does this fix it? diff --git a/include/builddefs.in b/include/builddefs.in index 94d25fc..4d6bb2d 100644 --- a/include/builddefs.in +++ b/include/builddefs.in @@ -26,7 +26,7 @@ MALLOCLIB = @malloc_lib@ LOADERFLAGS = @LDFLAGS@ LTLDFLAGS = @LDFLAGS@ CFLAGS = @CFLAGS@ -D_FILE_OFFSET_BITS=64 -BUILD_CFLAGS = @BUILD_CFLAGS@ +BUILD_CFLAGS = @BUILD_CFLAGS@ -D_FILE_OFFSET_BITS=64 LIBRT = @librt@ LIBUUID = @libuuid@ > First bad commit is: > commit 0a71e38396304b4d1215ba0b51cd6ce8e33eb40d > Author: Gwendal Grignou <gwendal@xxxxxxxxxxxx> > Date: Thu Jan 12 14:12:29 2017 -0600 > > build: Allow compiling xfsprogs in a cross compile environment > > Without this patch, we are using the same compiler and options for the host > compiler (BUILD_CC) and the target compiler (CC), and we would get error > messages at compilation: > x86_64-pc-linux-gnu-gcc -O2 -O2 -pipe -march=armv7-a -mtune=cortex-a15 ... > x86_64-pc-linux-gnu-gcc.real: error: unrecognized command line option > '-mfpu=neon' > '-mfloat-abi=hard' > '-clang-syntax' > '-mfpu=neon' > '-mfloat-abi=hard' > '-clang-syntax' > > Add BUILD_CC and BUILD_CFLAGS as precious variables to allow setting it up > from the ebuild. > > Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx> > Reviewed-by: Mike Frysinger <vapier@xxxxxxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx> > > Thanks, > //richard > -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html