On Wed, Jan 11, 2017 at 6:23 PM, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote: > On 1/11/17 12:30 AM, Amir Goldstein wrote: >> The size of the xfs_mode_to_ftype[] conversion table >> was too small to handle an invalid value of mode=S_IFMT. >> >> Instead of fixing the table size, replace the conversion table >> with a conversion helper that uses a switch statement. >> >> Suggested-by: Christoph Hellwig <hch@xxxxxx> >> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> >> --- >> libxfs/xfs_dir2.c | 36 ++++++++++++++++++++++-------------- >> libxfs/xfs_dir2.h | 5 ++--- >> repair/dino_chunks.c | 6 +----- >> repair/phase6.c | 2 +- >> 4 files changed, 26 insertions(+), 23 deletions(-) >> >> Eric, >> >> This is a matching patch to the one that got Reviewed-by Darrick for kernel. >> >> Tested xfs_repair with the new xfs/348 test with -n ftype=0|1. > > Thanks, I'll pull this in after Darrick commits it to the kernel. > FYI, commit is in kernel and xfstest xfs/348 which sanity tests xfs_repair with this change is already merged as well. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html