On Wed, Dec 07, 2016 at 02:27:27PM +0100, Jan Tulak wrote: > No need for this separate check, when we can use getstr() for opts. > > Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx> Reviewed-by: Bill O'Donnell <billodo@xxxxxxxxxx> > --- > mkfs/xfs_mkfs.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c > index 9e726f7..9c1ad11 100644 > --- a/mkfs/xfs_mkfs.c > +++ b/mkfs/xfs_mkfs.c > @@ -2560,11 +2560,10 @@ main( > value, &opts[OPT_M], M_FINOBT); > break; > case M_UUID: > - if (!value || *value == '\0') > - reqval('m', subopts, M_UUID); > + opts[OPT_M].subopt_params[M_UUID].value.s = > + getstr(value, &opts[OPT_M], M_UUID); > if (platform_uuid_parse(value, &uuid)) > illegal(optarg, "m uuid"); > - opts[OPT_M].subopt_params[M_UUID].value.s = value; > break; > case M_RMAPBT: > sb_feat.rmapbt = getnum( > -- > 2.8.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html