Re: [PATCH 09/22] mkfs: change conflict checks to utilize the new conflict structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 13, 2017 at 6:08 PM, Bill O'Donnell <billodo@xxxxxxxxxx> wrote:
> On Wed, Dec 07, 2016 at 02:27:16PM +0100, Jan Tulak wrote:
>> Bring the conflicts detection up to date with conflicts declaration.
>>
>> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx>
>
> There's a missing definition for check_subopt()
> FWIW, I see the call gets removed in patch10.
>
>> ---
>>  mkfs/xfs_mkfs.c | 37 +++++++++++++++++++++++++++++++------
>>  1 file changed, 31 insertions(+), 6 deletions(-)
>>
>> [snip...]
>>
>> @@ -1517,7 +1540,7 @@ getstr(
>>       struct opt_params       *opts,
>>       int                     index)
>>  {
>> -     check_opt(opts, index, true);
>> +     check_subopt(opts, index, true);
>
> check_subopt is undefined. ^^^

Should be renamed to check_subopt_conflicts here, even if it is
deleted in the next patch.

-- 
Jan Tulak
jtulak@xxxxxxxxxx / jan@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux