> if (need_iolock) {
> if (!xfs_ilock_nowait(ip, XFS_IOLOCK_EXCL))
> return -EAGAIN;
> }
> + inode_dio_wait(VFS_I(ip));
inode_dio_wait generally is only safe to call with i_rwsem held
exclsuively, so if we'd need the call for the !need_iolock this would
be broken. Fortunately we don't even need the call in that case, so
this should be safe. I'd still prefer to move the inode_dio_wait call
into the need_iolock block to make that clear, though.
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
