On Tue, Jan 10, 2017 at 03:34:05PM -0600, Eric Sandeen wrote: > On 1/10/17 3:27 PM, Darrick J. Wong wrote: > >> What about sanitizing only the agcount, and saying something like: > >> > >> xfs_db: device fsfile AG count is insane. Initializing only first $X > >> > >> (where $X is based on your heuristics) > > I feel like "Initializing" could be misinterpreted as formatting the > > disk. How about: > > > > xfs_db: device fsfile AG count is insane. Reading only the first $X AGs. > > Sure. (I'm not sure what the implications are - it's more than just > "Oh, we didn't read it" right? It'll have implications for use if > more AGs really exist?) I don't think there are. AFAICT we don't ever write the m_sb values back to disk; the only commands capable of writing (blocktrash, write, fuzz) deal with buffers directly. There's a side effect that things like metadump will only dump the first $X AGs worth of metadata, but right now it'll simply OOM and crash. --D > > -Eric > > > ? > > > > --D > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
