On 12/29/2016 12:09 PM, Christoph Hellwig wrote: > On Thu, Dec 29, 2016 at 08:42:08AM -0600, Alex Elder wrote: >> This sounds like a good idea, though I haven't really reviewed >> the code itself. But I'd say a one line comment indicating why >> errors from _xfs_log_force() are being ignored might be good. > > I don't really know the answer, but it probabls is: some callers > shouldn't ignore it and others can't handle it either. Maybe I'll > need to some further work in this area, but it's not really > related to dropping the message. > I actually misspoke. What I *meant* to say was that a comment about why we don't want to log a message in these spots might be nice. But now I'm less interested in that and more interested in why errors from _xfs_log_force*() can be ignored. Anyway, I won't claim to have reviewed this, but your change makes sense to me. -Alex -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
