Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 21 Dec 2016 11:12:55 -0800
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, CAI Qian <caiqian@xxxxxxxxxx>, linux-xfs <linux-xfs@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, Nick Piggin <npiggin@xxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
In-reply-to: <87shphaz78.fsf@linux-m68k.org>
References: <20160917190023.GA8039@ZenIV.linux.org.uk> <20160923190032.GA25771@ZenIV.linux.org.uk> <20160923190326.GB2356@ZenIV.linux.org.uk> <CA+55aFxzPH2AYvDVWSAomO6bN_sW4+qDv87Xbq8XHMyvBEYe+w@mail.gmail.com> <20160923201025.GJ2356@ZenIV.linux.org.uk> <CA+55aFyr-X_6FcWkSXBUcxV0p1BUZw8d=46wawv2x+8y7f8YcQ@mail.gmail.com> <20160924035951.GN2356@ZenIV.linux.org.uk> <87shpmxrey.fsf@linux-m68k.org> <CA+55aFyJGz6njFjKe8O0+XRJhCrPHA_wnEuLbGSGypJ0G2-vpQ@mail.gmail.com> <20161218201207.GY1555@ZenIV.linux.org.uk> <20161218203003.GZ1555@ZenIV.linux.org.uk> <CA+55aFzPE6FbwX2NuiMkz9G+FzAoiNeb8jOSWwSoX3O7+KuH4Q@mail.gmail.com> <87shphaz78.fsf@linux-m68k.org>

On Wed, Dec 21, 2016 at 10:56 AM, Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
>
> FWIW, I have verified that the testsuite of pv succeeds with this patch:

Ok, thanks, committed.

Al, looking at this area, I think there's some room for cleanups. In
particular, isn't the loop in opipe_prep() now just
"wait_for_space()"? I'm also thinking that we could perhaps remove the
SIGPIPE/EPIPE handling from splice_to_pipe()..

Hmm?

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

References:
- Re: xfs_file_splice_read: possible circular locking dependency detected
  - From: Al Viro
- [RFC][CFT] splice_read reworked
  - From: Al Viro
- [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe()
  - From: Al Viro
- Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe()
  - From: Linus Torvalds
- Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe()
  - From: Al Viro
- Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe()
  - From: Linus Torvalds
- [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()
  - From: Al Viro
- Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()
  - From: Andreas Schwab
- Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()
  - From: Linus Torvalds
- Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()
  - From: Al Viro
- Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()
  - From: Al Viro
- Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()
  - From: Linus Torvalds
- Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()
  - From: Andreas Schwab

Prev by Date: Re: [PATCH v3] Fix building xfsprogs on 32-bit platforms
Next by Date: Re: [PATCH v3] Fix building xfsprogs on 32-bit platforms
Previous by thread: Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()
Next by thread: [PATCH 06/12] new helper: add_to_pipe()
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]