On 12/20/16 2:31 AM, Christoph Hellwig wrote:
> On Fri, Dec 16, 2016 at 03:41:12PM +1100, Dave Chinner wrote:
>> From: Dave Chinner <dchinner@xxxxxxxxxx>
>>
>> Simplify the command loop further by merging the command loop
>> iteration checks with the command execution function. This removes
>> all visibility of command iteration from the main command execution
>> loop, and enables us to factor and clean up the command loop
>> processing neatly.
>>
>> Signed-Off-By: Dave Chinner <dchinner@xxxxxxxxxx>
>
> Looks fine, but some minor nitpicks below:
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by, maybe?
>
>> +static int
>> +process_input(
>
> return bool instead of int (and switch done in the caller to bool as
> well)?
Everything below it is an int, fwiw, seems like a job for another day.
>> + char *input,
>> + bool iterate)
>> {
>> - int c, i, j = 0, done = 0;
>> - char *input;
>
> Align the arguments to the same row as the variables below it?
I'll fix that on merge.
Thanks,
-Eric
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
