Re: [PATCH] xfs_quota: handle wrapped id from GETNEXTQUOTA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 16, 2016 at 06:13:53PM -0600, Eric Sandeen wrote:
> The GETNEXTQUOTA interface in the kernel had a bug
> (at least in xfs) where if we pass in UINT_MAX as the
> ID, it incremented, warpped, and returned 0 for the next
> id.  This would cause userspace to start querying
> again at zero, and an xfs_quota "report" command would
> loop forever.  This occurred if a quota ID near
> UINT max existed, and later offsets within the block
> wrapped the xfs_dqid_t.
> 
> This will also be fixed in the kernel, but we should also
> catch this in userspace, and stop the loop if it happens.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux