Re: [PATCH 5/6] xfs_io: make various commands one-shot only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 15, 2016 at 07:50:33PM -0600, Eric Sandeen wrote:
> On 12/15/16 6:53 PM, Dave Chinner wrote:
> > On Thu, Dec 15, 2016 at 12:21:43PM -0600, Eric Sandeen wrote:
> > Because they are aimed at single, specific filesystem operations
> > only. It just doesn't make sense to iterate them across all open
> > files inside xfs_io. If you have multiple filesystems youneed to
> > query/modify, then do an xfs_io call for each. 
> 
> Ok, I guess this finally clicked for me; a very easily described
> test for whether the flag gets set:
> 
>   Only operations which specifically operate on /files/ will iterate*.
> 
>   System-wide and fs-wide operations (even if they happen to take a
>   file as an argument, as i.e. freeze can) do /not/ iterate.
> 
> *and open doesn't iterate because recursion :)
> 
> I'm happy with that, though I think it should be documented clearly.
> 
> Sorry if I was slow getting to your point.

No, you're not slow, I simply couldn't explain my rationale as
clearly and obviously as you've just done. I'll add that to my man
page updates, and repost the series for you.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux