On Mon, Dec 5, 2016 at 5:26 PM, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote: > On 12/5/16 9:19 AM, Amir Goldstein wrote: >> On Mon, Dec 5, 2016 at 4:19 PM, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote: >>> On 12/5/16 7:03 AM, Amir Goldstein wrote: >>>> There is an undocumented and possibly unused feature in xfs_io >>>> where all commands are executed per file in the file args list. >>>> >>>> This feature creates ambiguity when trying to execute commands >>>> such as "open" and "file" from command line and result in an >>>> endless loop in the command loop code. >>> >>> I may well be dense, but it's not immediately obvious what the >>> old and/or problematic behavior is. Can you spell it out a bit >>> more? What is an example of this loop? >> >> $ touch foo >> $ xfs_io -c "open foo" foo >> >> you will see the shit storm > > ;) Ok thanks. (would be nice to have that in the changelog) > Good point. I will add that. > > Given that neither the manpage nor the short help mention that more than > one filename is accepted, should this even succeed at all? > Make sense to me to fail on multiple file args. This is a behavior change that will not go silently if anyone is actually using multiple file args. If there are no objections, I will send out v4 patch. The only documentation change I am going to make is put the [file] arg in usage (and man page) inside optional brackets []. I think the rest of the behavior is pretty much aligned with the existing documentation. Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
