Re: [PATCH] Fix building xfsprogs on 32-bit platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 28, 2016 at 02:42:35PM -0800, Eric Biggers wrote:
> Since commit 7fda99a0c297 ("xfs.h: require transparent LFS for all
> users"), building xfsprogs fails on a 32-bit platform because it does
> not define _FILE_OFFSET_BITS=64 itself.  Fix it by adding this to CFLAGS
> in builddefs.in.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
>  include/builddefs.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/builddefs.in b/include/builddefs.in
> index aeb2905..5219071 100644
> --- a/include/builddefs.in
> +++ b/include/builddefs.in
> @@ -25,7 +25,7 @@ OPTIMIZER = @opt_build@
>  MALLOCLIB = @malloc_lib@
>  LOADERFLAGS = @LDFLAGS@
>  LTLDFLAGS = @LDFLAGS@
> -CFLAGS = @CFLAGS@
> +CFLAGS = @CFLAGS@ -D_FILE_OFFSET_BITS=64

So, umm, why aren't these lines in configure.ac setting this already
on your system?

AC_SYS_LARGEFILE
AC_NEED_LFS

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux