On Fri, Nov 18, 2016 at 09:20:47AM +0100, Christoph Hellwig wrote: > On Thu, Nov 17, 2016 at 01:33:30PM -0500, Brian Foster wrote: > > My cow prealloc series is going to end up adding this right back, fwiw. > > Though at that point it's not really "prev" as used throughout the > > extent manipulation code, but rather just an extent on which to base the > > initial prealloc size. > > Oh, well. I could keep the argument for now, but doing the lookups > in the caller just for the prev value that's not even always used > seems a little silly. It's probably not worth it. This looks like a good clean up to me as it is... I just wanted to call that out since I was using/changing 'prev'. Looking again, the cow prealloc stuff is still going to use the data extent record. I may be able to convert 'prev' to 'base' within *_prealloc_size() just the same without changing the function signature back. Brian > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
