On Tue, Nov 15, 2016 at 01:11:25PM -0500, Brian Foster wrote: > On Tue, Nov 15, 2016 at 06:28:26AM -0800, Christoph Hellwig wrote: > > > + /* > > > + * Search for a preexisting extent. COW fork allocation may still be > > > + * required for reflink inodes if the data extent is shared. > > > + */ > > > xfs_bmap_search_extents(ip, offset_fsb, XFS_DATA_FORK, &eof, &idx, > > > &got, &prev); > > > imap = got; > > > > Maybe we should look up directly into imap and now duplicate that > > information for imap and got? > > > > Didn't you recently change this code from doing that? I'm not following > how changing it back helps us... You only introduce imap in the previous patch. I'd just try to avoid copying the irec structures as much as possible. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
