> + if (imap->br_startoff != got.br_startoff || > + imap->br_blockcount != got.br_blockcount) > xfs_inode_set_cowblocks_tag(ip); Can't got.br_blockcount be smaller than imap->br_blockcount if we have an existing COW fork reservation lying around behind the whole we're filling? Also they way xfs_bmapi_reserve_delalloc works the startoff will be the same. E.g. this check should probably be: if (got.br_blockcount > imap->br_blockcount) Except for that the patch looks good and is a nice cleanup. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
