Re: [PATCH 16/16] xfs: check minimum block size for CRC filesystems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	if (xfs_sb_version_hascrc(&mp->m_sb) &&
> +	    unlikely(
> +	    sbp->sb_blocksize < XFS_MIN_CRC_BLOCKSIZE)) {
> +		xfs_notice(mp, "v5 SB sanity check failed");
> +		return -EFSCORRUPTED;
> +	}

No need to uglify mount, which is a slow path with unlikely annotations.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux