On Fri, Oct 28, 2016 at 01:11:55PM +0300, Avi Kivity wrote: > With these patches, is it reasonable to run with discard enabled, or is > more work needed? As usual the answer is: it depends. With the high-end NVMe devices I've been testing with you absolutely should enable discard. With SAS SSDs the same is probably true. I haven't done much testing with SATA SSDs but I'd be more cautious there, especially as very few seem to support queued TRIM yet. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html