Re: [PATCH 1/3] xfs: fix up inode cowblocks tracking tracepoints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 21, 2016 at 01:22:11PM -0400, Brian Foster wrote:
> These calls are still using the eofblocks tracepoints. The cowblocks
> equivalents are already defined, we just aren't actually calling them.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Good catch!

Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

> ---
>  fs/xfs/xfs_icache.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 14796b7..f295049 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -1656,9 +1656,9 @@ void
>  xfs_inode_set_cowblocks_tag(
>  	xfs_inode_t	*ip)
>  {
> -	trace_xfs_inode_set_eofblocks_tag(ip);
> +	trace_xfs_inode_set_cowblocks_tag(ip);
>  	return __xfs_inode_set_eofblocks_tag(ip, xfs_queue_cowblocks,
> -			trace_xfs_perag_set_eofblocks,
> +			trace_xfs_perag_set_cowblocks,
>  			XFS_ICI_COWBLOCKS_TAG);
>  }
>  
> @@ -1666,7 +1666,7 @@ void
>  xfs_inode_clear_cowblocks_tag(
>  	xfs_inode_t	*ip)
>  {
> -	trace_xfs_inode_clear_eofblocks_tag(ip);
> +	trace_xfs_inode_clear_cowblocks_tag(ip);
>  	return __xfs_inode_clear_eofblocks_tag(ip,
> -			trace_xfs_perag_clear_eofblocks, XFS_ICI_COWBLOCKS_TAG);
> +			trace_xfs_perag_clear_cowblocks, XFS_ICI_COWBLOCKS_TAG);
>  }
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux