Re: [PATCH] xfs: don't take the IOLOCK exclusive for direct I/O page invalidation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon 17-10-16 14:13:12, Christoph Hellwig wrote:
> XFS historically took the iolock exclusive when invalidating pages
> before direct I/O operations to protect against writeback starvations.
> 
> But this writeback starvation issues has been fixed a long time ago
> in the core writeback code, and all other file systems manage to do
> without the exclusive lock.  Convert XFS over to avoid the exclusive
> lock in this case, and also move to range invalidations like done
> by the other file systems.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

The patch looks good to me. You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux