Re: [PATCH v2] xfs_io: add command line option -M to run as multi threaded process

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 16, 2016 at 11:55:11AM +0300, Amir Goldstein wrote:
> xfs_io -M will start by spawning an idle thread.
> The purpose of this idle thread is to test io from a multi threaded
> process. With single threaded process, the file table is not shared
> and file structs are not reference counted.

I can see this option being confusing to those who do not understand
what is actually be done here. i.e. we'll get complaints along the
lines of "-M say xfs_io does multithreaded IO, but I only see IO
from one thread!". Can we name this "-i" to mean "run an idle-loop",
which will stop people trying to use it for something it doesn't do?

> --- a/io/Makefile
> +++ b/io/Makefile
....
> --- a/io/init.c
> +++ b/io/init.c
....

Missing a man page update to document this new option.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux