Re: [LTP] [PATCH] m4/ltp-xfs_quota.m4: fix xfs quota check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!
> Current check doesn't work since xfsprogs v4.5.0.
> Undefined off64_t type leads to this issue, so we
> need to define _GNU_SOURCE to make off64_t defined.
> 
> This has been broken by upstream xfsporgs-dev commmit
> 
> commit cb898f157f8410a03cf5f3400baa1df9e5eecd33
> Author: Felix Janda <felix.janda@xxxxxxxxx>
> Date: Fri Feb 5 08:34:06 2016 +1100
> 
>   linux.h: Use off64_t instead of loff_t

That kind of looks like a bug in xfs-progs, since off64_t is not exposed
from glibc unless we enable either largefile support or define
_GNU_SOURCE. As a matter of fact the _GNU_SOURCE enables
_LARGEFILE64_SOURCE which then enables the typedef that exposes the
off64_t typedef.

So they are depending on a type that is not defined by default but since
the code has been part of at least three releases already we have to
apply the workaround for it anyway.

Patch pushed, thanks.

[CCing the XFS mailing list in case they want to do something about it]

-- 
Cyril Hrubis
chrubis@xxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux