On Mon, Oct 10, 2016 at 05:45:00AM -0700, Christoph Hellwig wrote: > On Mon, Oct 10, 2016 at 11:25:08PM +1100, Dave Chinner wrote: > > On Mon, Oct 10, 2016 at 03:24:18AM -0700, Christoph Hellwig wrote: > > > On Fri, Oct 07, 2016 at 04:08:03PM -0700, Darrick J. Wong wrote: > > > > Since we can only turn on the rt flag if there are no data extents, > > > > we can safely turn off the reflink flag if the rt flag is being > > > > turned on. > > > > > > Why would the reflink flag ever be turned on if we have no data extents? > > > > After a truncate? > > Any why don't we simply clear the flag when we know there can't be > any shared extents left? We /do/ clear the flag if we truncate everything out of the file. See the end of xfs_itruncate_extents(). --D -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html