On Fri, Sep 30, 2016 at 12:24:40AM -0700, Christoph Hellwig wrote: > On Thu, Sep 29, 2016 at 08:07:39PM -0700, Darrick J. Wong wrote: > > Create bmbt update intent/done log items to record redo information in > > the log. Because we roll transactions multiple times for reflink > > operations, we also have to track the status of the metadata updates > > that will be recorded in the post-roll transactions in case we crash > > before committing the final transaction. This mechanism enables log > > recovery to finish what was already started. > > Looks fine: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > but the amount of boilerplate code we add for each log item really > worries me. We should think of a way to avoid all that code > duplication. Yeah, the boilerplate both here and especially for btree rebuilding in xfs_repair phase 5 worry me. I've heard chatter about creating another redo item type to handle directory parent pointers; that's probably a good time to refactor the log item things. Not sure about repair, maybe that's tackleable as part of xfsprogs 4.9. --D -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
