> /* > + * xfs_bunmapi_cow() -- Remove the relevant parts of the CoW fork. > + * See xfs_bmap_del_extent. > + * @ip: XFS inode. > + * @idx: Extent number to delete. > + * @del: Extent to remove. > + */ Not quite a kerneldoc comment, not quite a normal one either.. That being sai the function seems mostly like a copy of the delay part of xfs_bmap_del_extent and the duplication seems unfortunate. As I plan to do a major rework of that area for the next merge window I don't mind it for now, though. > + xfs_bmbt_irec_t *del) Same for these uses of the old typedefs in new code. I'd rather avoid those, but instead of introducing churn now I'll sort this out later. So: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
