On Thu, Sep 29, 2016 at 10:05:37AM -0700, Christoph Hellwig wrote: > On Tue, Sep 27, 2016 at 07:58:13PM -0700, Darrick J. Wong wrote: > > +#define BMV_IF_COWFORK 0x20 /* return CoW fork rather than data */ > > I think exposing an implementation detail like the COW fork that has > no on-disk equivalent is a bad idea and would feel much better if this > part of the patch was dropped. There are a few xfstests that check the contents of the CoW extent fork to make sure it's working properly. How about a compromise -- leave the flag in, but return -EINVAL unless CONFIG_XFS_DEBUG=y ? --D -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
