> +int > +xfs_cui_copy_format( > + struct xfs_log_iovec *buf, > + struct xfs_cui_log_format *dst_cui_fmt) > +{ > + struct xfs_cui_log_format *src_cui_fmt; > + uint len; > + > + src_cui_fmt = buf->i_addr; > + len = xfs_cui_log_format_sizeof(src_cui_fmt->cui_nextents); > + > + if (buf->i_len == len) { > + memcpy(dst_cui_fmt, src_cui_fmt, len); > + return 0; > + } > + return -EFSCORRUPTED; > +} I'd still much prefer this to be inlined in the only caller. But except for that this looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html