On Tue, Sep 27, 2016 at 01:10:28PM -0500, Eric Sandeen wrote: > libxfs_iget() is always called with bno == 0. > Which is probably a good thing, because it then passes > bno to xfs_iread as iget_flags! > > So remove the libxfs_iget arg, and explicitly pass > 0 to xfs_iread for flags. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > --- > > (or should we just rename/re-type bno to a flags arg?) Killing it seems fine to me. Any argument not actually used is just asking for bugs like the one you just fixed. Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html