I've got a bug report with a slightly older version of the reflink code, in which I get a bogus NULL xfs_bmbt_rec_host pointer back from xfs_iext_bno_to_ext in xfs_reflink_find_cow_mapping. I've not reproduced that bug myself yet, but what's clear from the report is that it's not just inefficient but also potentially dangerous to do the blind dereference in xfs_reflink_find_cow_mapping after we dropped the ilock from the previous xfs_reflink_find_cow_mapping call. So just combine that two into one function, and then rewrite the COW writeback code to only do a single call in the second step. I think that also cleans up the writeback code quite a bit and makes it much easier to follow as well. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
