On 9/18/16 9:16 PM, Dave Chinner wrote: > On Fri, Sep 16, 2016 at 03:48:14PM -0500, Eric Sandeen wrote: >> When CRCs were made default, a few leftovers related to its >> prior non-default status remained in the manpage, in the ftype >> section. Clean those up. >> >> Reported-by: Chris Murphy <chris@xxxxxxxxx> >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> >> --- >> >> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8 >> index 9578c4d..033bc36 100644 >> --- a/man/man8/mkfs.xfs.8 >> +++ b/man/man8/mkfs.xfs.8 >> @@ -636,13 +636,13 @@ do not need to look up the inode to determine the inode type. >> >> The >> .I value >> -is either 0 or 1, with 1 signifiying that filetype information >> -will be stored in the directory structure. The default value is 0. >> +is either 0 or 1, with 1 signifying that filetype information >> +will be stored in the directory structure. >> >> -When CRCs are enabled via >> -.B \-m crc=1, >> -the ftype functionality is always enabled. This feature can not be turned >> -off for such filesystem configurations. >> +When CRCs are enabled (the default), the ftype functionality is always >> +enabled, and cannot be turned off. If CRCs are disabled with >> +.B \-m crc=0, >> +the ftype functionality is disabled by default. > > I think that's wrong: > > $ sudo mkfs.xfs -f -m crc=0 /dev/vda > .... > naming =version 2 bsize=4096 ascii-ci=0 ftype=1 > ^^^^^^^ > > i.e. ftype is enabled by default for all configurations these days. Oh hell, you're right. I'll resend. In retrospect that was probably a mistake, but it is what it is :) -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
