On Thu, Sep 15, 2016 at 07:12:29AM +0200, Christoph Hellwig wrote: > On Wed, Sep 14, 2016 at 11:07:59AM -0600, Ross Zwisler wrote: > > I'll bite - why do you think adding a space before labels is a "fairly > > horrible style"? Adding them gives a tangible benefit for unified diffs and > > patches because it's much more useful to know that a change is in a given > > function than that it follows a label called "out", which could be defined > > many times in a given file. Again, the example: > > It's a space based indent in a tab based world. And with git you can > get your enhanced diff output with just a small tweak to the git setting. > Which we're incidentally about to finally get for the kernel tree. What setting /is/ that, by the way? --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
