On Sat, Sep 10, 2016 at 08:55:57AM +1000, Dave Chinner wrote: > THe errors from the above two cases are not acted on. they are > immediately overwritten by: Yes, Robert also pointed this out. Fix below. > Is there a missing "if (error) goto out;" check somewhere here? Just the one above. > I'm also wondering if you've looked at supporting the PMD fault case > with iomap? PMD faults currently don't work at all. Ross has a series to resurrect them, but we'll need to coordinate between the two series somehow. My preference would be to not resurrect them for the bh path and only do it for the iomap version. diff --git a/fs/dax.c b/fs/dax.c index a170a94..5534594 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1440,6 +1440,7 @@ int iomap_dax_fault(struct vm_area_struct *vma, struct vm_fault *vmf, default: WARN_ON_ONCE(1); error = -EIO; + goto unlock_entry; } /* Filesystem should not return unwritten buffers to us! */ -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
