On 24.11.2022 14:51, Andy Shevchenko wrote:
> On Thu, Nov 24, 2022 at 01:57:53PM +0100, Matija Glavinic Pecotic wrote:
>> set_rtc_noop, get_rtc_noop are used runtime, therefore need init removed.
>> Problem was observed on x86 platform where cmos rtc is unused and disabled
>> via device tree. Function was triggered from ntp: sync_hw_clock, although
>> CONFIG_RTC_SYSTOHC=n, however sync_cmos_clock doesn't honour that.
>
>> Oops: 0011 [#1] PREEMPT SMP NOPTI
>> Workqueue: events_power_efficient sync_hw_clock
>> RIP: 0010:set_rtc_noop
>> Call Trace:
>> update_persistent_clock64
>> sync_hw_clock
>
> (see below)
>
>> process_one_work
>> worker_thread
>> ? rescuer_thread
>> kthread
>> ? kthread_create_worker_on_cpu
>> ret_from_fork
>
> This looks much better, but you can shrink even more.
Thanks for the patience here. Would this be something shrink enough,
but still preserving all important information (such as it is oops, it
crashed in set_rtc_noop, and it is sync_hw_clock which triggered it)
Oops: 0011 [#1] PREEMPT SMP NOPTI
Workqueue: events_power_efficient sync_hw_clock
RIP: 0010:set_rtc_noop
Call Trace:
update_persistent_clock64
sync_hw_clock
...
>> Fixes: c311ed6183f4 ("x86/init: Allow DT configured systems to disable RTC at boot time")
>>
>> Signed-off-by: Matija Glavinic Pecotic <matija.glavinic-pecotic.ext@xxxxxxxxx>
>
> Right, the second aspect of tag being tag I mentioned. So, the usual message
> skeleton looks like
>
> prefix: Summary of the change
> ...blank line...
> Commit message body.
> ...blank line...
> Tag1:
> Tag2:
> Signed-off-by: Sumbitter
>
> Note, that the last, tag block mustn't have blank lines, that what makes tags
> to be tags.
Got it, thanks!
> Btw, '__init' should be in the Subject, otherwise it's unclear what it means.
Sure, I will add it.
