Re: [discuss] [PATCH] [40/66] x86_64: Quieten down microcode update driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 27 March 2006 05:23, Jin, Gordon wrote:
> Andi Kleen wrote:
> > On Monday 27 March 2006 05:08, Jin, Gordon wrote:
> > 
> >> 
> >> How about changing the printk to pr_debug, other than removing them
> >> completely? This can facilitate debugging, as well as keeping normal
> >> log clean. 
> > 
> > When you want to debug something you can add the printks.  I don't
> > think they're useful for the general user populace. 
> > 
> > -Andi
> 
> But there're already so many pr_debug used in microcode.c, and most of
> them are even less useful than what you are deleting.
> It doesn't fit logic to keep less useful info in pr_debug, but deleting
> more
> useful info completely.

I wouldn't have a problem with deleting them all.

-Andi
-
: send the line "unsubscribe linux-x86_64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux ia64]     [Linux Kernel]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux Hams]
  Powered by Linux