Re: [PATCH] [65/66] x86_64: Enable VIA AGP driver on x86-64 for VIA P4 chipsets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 23, 2006 at 09:31:34PM +0100, Andi Kleen wrote:
 > 
 > Untested so far
 > 
 > Cc: davej@xxxxxxxxxx
 > 
 > Signed-off-by: Andi Kleen <ak@xxxxxxx>
 > 
 > ---
 >  drivers/char/agp/Kconfig |    2 +-
 >  1 files changed, 1 insertion(+), 1 deletion(-)
 > 
 > Index: linux/drivers/char/agp/Kconfig
 > ===================================================================
 > --- linux.orig/drivers/char/agp/Kconfig
 > +++ linux/drivers/char/agp/Kconfig
 > @@ -103,7 +103,7 @@ config AGP_SWORKS
 >  
 >  config AGP_VIA
 >  	tristate "VIA chipset support"
 > -	depends on AGP && X86_32
 > +	depends on AGP
 >  	help
 >  	  This option gives you AGP support for the GLX component of
 >  	  X on VIA MVP3/Apollo Pro chipsets.

I made the same change locally, but haven't checked it in, because
I have concerns about this breaking AMD systems with VIA GARTs.
We don't handle the case where we have two drivers wanting to
'be' /dev/agpgart too well.

If we had an AMD64 + VIA GART, then I think currently link-order
makes it 'first one wins', and the second driver might just fail
to register. Not sure.

Maybe in such a situation, we should let the chipset gart be
/dev/agpgart, and use the on-cpu gart solely for IOMMU.

What do you think?

		Dave

-- 
http://www.codemonkey.org.uk
-
: send the line "unsubscribe linux-x86_64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux ia64]     [Linux Kernel]     [DCCP]     [Linux ARM]     [Yosemite News]     [Linux SCSI]     [Linux Hams]
  Powered by Linux