On Thursday 23 March 2006 22:37, Joel Becker wrote: > On Thu, Mar 23, 2006 at 09:28:24PM +0100, Andi Kleen wrote: > > Every time hangcheck is compiled in it eventually spams the kernel log > > with: > > > > Hangcheck: hangcheck value past margin! > > > > This confuses users who usually think it is a generic kernel bug. > > Just remove the message. As far as I can see it is useless. The only > > value of hangcheck is to reboot the machine if configured. > > NAK. The value of not-rebooting is to test "hey, you delayed to > much, you would have rebooted". While a production system might want a > reboot, a developer just wants to know it happened. > If you are getting the print, something is horking the box or > hangcheck is horked. We should fix the bug. It happens without anybody ever using hangcheck for anything. It's just compiled in. You shouldn't assume everybody cares about that hang checking thing just because the driver is loaded. All the other watchdogs in Linux are only active when at least one person ever opened the device. That ought be right behaviour for hangcheck too. -Andi - : send the line "unsubscribe linux-x86_64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
