since skb->len is unsigned this is always true. vi net/x25/af_x25.c +954 if (skb->len >= 0) { skb_copy_from_linear_data(skb, makex25->calluserdata.cuddata, skb->len); makex25->calluserdata.cudlength = skb->len; } shouldn't we instead do something like if (skb->len < LEN_MAX) and what should LEN_MAX be? -- To unsubscribe from this list: send the line "unsubscribe linux-x25" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html