Hi Dinghao, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.6-rc3 next-20230929] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dinghao-Liu/ieee802154-ca8210-Fix-a-potential-UAF-in-ca8210_probe/20231001-135130 base: linus/master patch link: https://lore.kernel.org/r/20231001054949.14624-1-dinghao.liu%40zju.edu.cn patch subject: [PATCH] [v3] ieee802154: ca8210: Fix a potential UAF in ca8210_probe config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231001/202310011548.qyQMuodI-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231001/202310011548.qyQMuodI-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202310011548.qyQMuodI-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/net/ieee802154/ca8210.c: In function 'ca8210_register_ext_clock': >> drivers/net/ieee802154/ca8210.c:2743:13: warning: unused variable 'ret' [-Wunused-variable] 2743 | int ret = 0; | ^~~ vim +/ret +2743 drivers/net/ieee802154/ca8210.c ded845a781a578 Harry Morris 2017-03-28 2731 ded845a781a578 Harry Morris 2017-03-28 2732 /** ded845a781a578 Harry Morris 2017-03-28 2733 * ca8210_register_ext_clock() - Register ca8210's external clock with kernel ded845a781a578 Harry Morris 2017-03-28 2734 * @spi: Pointer to target ca8210 spi device ded845a781a578 Harry Morris 2017-03-28 2735 * ded845a781a578 Harry Morris 2017-03-28 2736 * Return: 0 or linux error code ded845a781a578 Harry Morris 2017-03-28 2737 */ ded845a781a578 Harry Morris 2017-03-28 2738 static int ca8210_register_ext_clock(struct spi_device *spi) ded845a781a578 Harry Morris 2017-03-28 2739 { ded845a781a578 Harry Morris 2017-03-28 2740 struct device_node *np = spi->dev.of_node; ded845a781a578 Harry Morris 2017-03-28 2741 struct ca8210_priv *priv = spi_get_drvdata(spi); ded845a781a578 Harry Morris 2017-03-28 2742 struct ca8210_platform_data *pdata = spi->dev.platform_data; ded845a781a578 Harry Morris 2017-03-28 @2743 int ret = 0; ded845a781a578 Harry Morris 2017-03-28 2744 ded845a781a578 Harry Morris 2017-03-28 2745 if (!np) ded845a781a578 Harry Morris 2017-03-28 2746 return -EFAULT; ded845a781a578 Harry Morris 2017-03-28 2747 ded845a781a578 Harry Morris 2017-03-28 2748 priv->clk = clk_register_fixed_rate( ded845a781a578 Harry Morris 2017-03-28 2749 &spi->dev, ded845a781a578 Harry Morris 2017-03-28 2750 np->name, ded845a781a578 Harry Morris 2017-03-28 2751 NULL, ded845a781a578 Harry Morris 2017-03-28 2752 0, ded845a781a578 Harry Morris 2017-03-28 2753 pdata->extclockfreq ded845a781a578 Harry Morris 2017-03-28 2754 ); ded845a781a578 Harry Morris 2017-03-28 2755 ded845a781a578 Harry Morris 2017-03-28 2756 if (IS_ERR(priv->clk)) { ded845a781a578 Harry Morris 2017-03-28 2757 dev_crit(&spi->dev, "Failed to register external clk\n"); ded845a781a578 Harry Morris 2017-03-28 2758 return PTR_ERR(priv->clk); ded845a781a578 Harry Morris 2017-03-28 2759 } ded845a781a578 Harry Morris 2017-03-28 2760 d0603f3c78f0aa Dinghao Liu 2023-10-01 2761 return of_clk_add_provider(np, of_clk_src_simple_get, priv->clk); ded845a781a578 Harry Morris 2017-03-28 2762 } ded845a781a578 Harry Morris 2017-03-28 2763 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
