Hi Breno, On 06/06/2023 12:11, Breno Leitao wrote: > On Sun, Jun 04, 2023 at 11:17:56AM +0200, Willem de Bruijn wrote: >>> On Sat, Jun 03, 2023 at 10:21:50AM +0200, Willem de Bruijn wrote: >>>> On Fri, Jun 2, 2023 at 6:31 PM Breno Leitao <leitao@xxxxxxxxxx> wrote: >>>>> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx> >>>> >>>> Please check the checkpatch output >>>> >>>> https://patchwork.hopto.org/static/nipa/753609/13265673/checkpatch/stdout >>> >>> I am checking my current checkpatch before sending the patch, but I am >>> not seeing the problems above. >>> >>> My tree is at 44c026a73be8038 ("Linux 6.4-rc3"), and I am not able to >>> reproduce the problems above. >>> >>> $ scripts/checkpatch.pl v5/v5-0001-net-ioctl-Use-kernel-memory-on-protocol-ioctl-cal.patch >>> total: 0 errors, 0 warnings, 0 checks, 806 lines checked >>> v5/v5-0001-net-ioctl-Use-kernel-memory-on-protocol-ioctl-cal.patch has no obvious style problems and is ready for submission. >>> >>> Let me investigate what options I am missing when running checkpatch. >> >> The reference is to the checkpatch as referenced by patchwork: >> >> https://patchwork.kernel.org/project/netdevbpf/patch/20230602163044.1820619-1-leitao@xxxxxxxxxx/ >> >> The 80 character limit is a soft limit. But also note the CHECK >> statements on whitespace. > > Right. In order to enable the "CHECK" statments, we need to pass the > "--subjective" parameter to checpatch.pl > > That said, I am able to reproduce the same output now, using the > following command line: > > $ scripts/checkpatch.pl --subjective --max-line-length=80 The different results visible on Patchwork are posted by a CI using scripts hosted there: https://github.com/kuba-moo/nipa If you are interested to know how checkpatch.pl is executed, you can have a look there: https://github.com/kuba-moo/nipa/blob/master/tests/patch/checkpatch/checkpatch.sh#L16 I guess what you need is the "--strict" argument: > $ ./scripts/checkpatch.pl --strict --max-line-length=80 \ > --ignore=COMMIT_LOG_LONG_LINE,MACRO_ARG_REUSE,ALLOC_SIZEOF_STRUCT,NO_AUTHOR_SIGN_OFF,GIT_COMMIT_ID,CAMELCASE \ > -g HEAD Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net
