Hello. On 01.03.23 16:44, Miquel Raynal wrote:
Avoid crashing the machine by checking info->attrs[NL802154_ATTR_SCAN_TYPE] presence before de-referencing it, which was the primary intend of the blamed patch. Reported-by: Sanan Hasanov <sanan.hasanov@xxxxxxxxxxxxxxx> Suggested-by: Eric Dumazet <edumazet@xxxxxxxxxx> Fixes: a0b6106672b5 ("ieee802154: Convert scan error messages to extack") Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> --- net/ieee802154/nl802154.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c index 88380606af2c..a18fb98a4b09 100644 --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1412,7 +1412,7 @@ static int nl802154_trigger_scan(struct sk_buff *skb, struct genl_info *info) return -EOPNOTSUPP; }- if (!nla_get_u8(info->attrs[NL802154_ATTR_SCAN_TYPE])) {+ if (!info->attrs[NL802154_ATTR_SCAN_TYPE]) { NL_SET_ERR_MSG(info->extack, "Malformed request, missing scan type"); return -EINVAL; }
This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt
