Hi,
On Mon, Jan 30, 2023 at 11:34 AM Stefan Schmidt
<stefan@xxxxxxxxxxxxxxxxxx> wrote:
>
> Hello.
>
> On 30.01.23 16:43, Miquel Raynal wrote:
> > When compiling scan.c with C=1, Sparse complains with:
> >
> > sparse: expected unsigned short [usertype] val
> > sparse: got restricted __le16 [usertype] pan_id
> > sparse: sparse: cast from restricted __le16
> >
> > sparse: expected unsigned long long [usertype] val
> > sparse: got restricted __le64 [usertype] extended_addr
> > sparse: sparse: cast from restricted __le64
> >
> > The tool is right, both pan_id and extended_addr already are rightfully
> > defined as being __le16 and __le64 on both sides of the operations and
> > do not require extra endianness handling.
> >
> > Fixes: 3accf4762734 ("mac802154: Handle basic beaconing")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > ---
> > net/mac802154/scan.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/net/mac802154/scan.c b/net/mac802154/scan.c
> > index cfbe20b1ec5e..8f98efec7753 100644
> > --- a/net/mac802154/scan.c
> > +++ b/net/mac802154/scan.c
> > @@ -419,8 +419,8 @@ int mac802154_send_beacons_locked(struct ieee802154_sub_if_data *sdata,
> > local->beacon.mhr.fc.source_addr_mode = IEEE802154_EXTENDED_ADDRESSING;
> > atomic_set(&request->wpan_dev->bsn, -1);
> > local->beacon.mhr.source.mode = IEEE802154_ADDR_LONG;
> > - local->beacon.mhr.source.pan_id = cpu_to_le16(request->wpan_dev->pan_id);
> > - local->beacon.mhr.source.extended_addr = cpu_to_le64(request->wpan_dev->extended_addr);
> > + local->beacon.mhr.source.pan_id = request->wpan_dev->pan_id;
> > + local->beacon.mhr.source.extended_addr = request->wpan_dev->extended_addr;
> > local->beacon.mac_pl.beacon_order = request->interval;
> > local->beacon.mac_pl.superframe_order = request->interval;
> > local->beacon.mac_pl.final_cap_slot = 0xf;
>
> This patch has been applied to the wpan-next tree and will be
> part of the next pull request to net-next. Thanks!
fyi: in my opinion, depending on system endianness this is actually a bug.
- Alex
