Hi Stefan,
stefan@xxxxxxxxxxxxxxxxxx wrote on Wed, 12 Oct 2022 12:48:06 +0200:
> Hello Miquel.
>
> This patch has given me some checkpatch wawrnings and errors.
>
> Commit d9abecc4a0fc ("ieee802154: hwsim: Implement address filtering")
> ----------------------------------------------------------------------
> CHECK: Blank lines aren't necessary after an open brace '{'
> #53: FILE: drivers/net/ieee802154/mac802154_hwsim.c:162:
> + if (hw->phy->filtering == IEEE802154_FILTERING_4_FRAME_FIELDS) {
> +
>
> ERROR: code indent should use tabs where possible
> #128: FILE: drivers/net/ieee802154/mac802154_hwsim.c:237:
> + }$
>
> WARNING: please, no spaces at the start of a line
> #128: FILE: drivers/net/ieee802154/mac802154_hwsim.c:237:
> + }$
>
> total: 1 errors, 1 warnings, 1 checks, 143 lines checked
>
> I fixed this up in palce for you tp proceed with applying this patches. Just so you are aware.
I'm sorry for these, I focused on getting the feature more than on the
presentation and I forgot to re-run checkpatch after all the copy-paste
handling towards hwsim. Next time I'll fix it myself, don't hesitate to
tell me when this happens ;-)
Thanks,
Miquèl
