Re: [PATCHv2 wpan-next 0/2] mac802154: atomic_dec_and_test() fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Jun 13, 2022 at 10:15 AM Miquel Raynal
<miquel.raynal@xxxxxxxxxxx> wrote:
>
> Hi Alex,
>
> aahringo@xxxxxxxxxx wrote on Mon, 13 Jun 2022 00:37:33 -0400:
>
> > Hi,
> >
> > I was wondering why nothing worked anymore. I found it...
> >
> > changes since v2:
> >
> >  - fix fixes tags in mac802154: util: fix release queue handling
> >  - add patch mac802154: fix atomic_dec_and_test checks got somehow
> >    confused 2 patch same issue
>
> I've got initially confused with your patchset but yes indeed the API
> works the opposite way compared to my gut understanding.
>

not the first time I am seeing this, I fixed similar issues already at
other places.

btw I told you the right semantic at [0] ....

> We bought hardware and I am currently setting up a real network to
> hopefully track these regressions myself in the future.
>

I wonder why you don't use hwsim... and you already mentioned hwsim to
me. You can simply make a 6lowpan interface on it and ping it - no
hardware needed and this would already show issues... Now you can say,
why I do not test it... maybe I do next time but review takes longer
then.

- Alex

[0] https://lore.kernel.org/linux-wpan/CAK-6q+jCYDQ-rtyawz1m2Yt+ti=3d6PrhZebB=-PjcX-6L-Kdg@xxxxxxxxxxxxxx/




[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux