Hi, On Mon, May 16, 2022 at 10:13 PM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > > > > On 5/16/2022 2:56 PM, Jakub Kicinski wrote: > > Most protocol-specific pointers in struct net_device are under > > a respective ifdef. Wireless is the notable exception. Since > > there's a sizable number of custom-built kernels for datacenter > > workloads which don't build wireless it seems reasonable to > > ifdefy those pointers as well. > > > > While at it move IPv4 and IPv6 pointers up, those are special > > for obvious reasons. > > > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > > Could not we move to an union of pointers in the future since in many > cases a network device can only have one of those pointers at any given > time? note that ieee802154 has also functionality like __dev_get_by_index() and checks via "if (netdev->ieee802154_ptr)" if it's a wpan interface or not, guess the solution would be like it's done in wireless then. - Alex
