Re: [PATCH wpan-next v2 1/5] net: ieee802154: Improve the way supported channels are declared

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Jan 28, 2022 at 6:08 AM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
>
> The idea here is to create a structure per set of channels so that we
> can define much more than basic bitfields for these.
>
> The structure is currently almost empty on purpose because this change
> is supposed to be a mechanical update without additional information but
> more details will be added in the following commits.
>

In my opinion you want to put more information in this structure which
is not necessary and force the driver developer to add information
which is already there encoded in the page/channel bitfields. Why not
add helper functionality and get your "band" and "protocol" for a
page/channel combination?

- Alex



[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux