Hi,
On Thu, 20 Jan 2022 at 06:21, Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
>
> Upon error the ieee802154_xmit_complete() helper is not called. Only
> ieee802154_wake_queue() is called manually. We then leak the skb
> structure.
>
> Free the skb structure upon error before returning.
>
> There is no Fixes tag applying here, many changes have been made on this
> area and the issue kind of always existed.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---
> drivers/net/ieee802154/at86rf230.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
> index 7d67f41387f5..0746150f78cf 100644
> --- a/drivers/net/ieee802154/at86rf230.c
> +++ b/drivers/net/ieee802154/at86rf230.c
> @@ -344,6 +344,7 @@ at86rf230_async_error_recover_complete(void *context)
> kfree(ctx);
>
> ieee802154_wake_queue(lp->hw);
> + dev_kfree_skb_any(lp->tx_skb);
as I said in other mails there is more broken, we need a:
if (lp->is_tx) {
ieee802154_wake_queue(lp->hw);
dev_kfree_skb_any(lp->tx_skb);
lp->is_tx = 0;
}
in at86rf230_async_error_recover().
Thanks.
- Alex
