Hi Alexander, alex.aring@xxxxxxxxx wrote on Mon, 17 Jan 2022 17:43:49 -0500: > Hi, > > On Mon, 17 Jan 2022 at 06:55, Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > ... > > > > /* stop hardware - this must stop RX */ > > diff --git a/net/mac802154/ieee802154_i.h b/net/mac802154/ieee802154_i.h > > index 0291e49058f2..37d5438fdb3f 100644 > > --- a/net/mac802154/ieee802154_i.h > > +++ b/net/mac802154/ieee802154_i.h > > @@ -122,6 +122,7 @@ extern struct ieee802154_mlme_ops mac802154_mlme_wpan; > > > > void ieee802154_rx(struct ieee802154_local *local, struct sk_buff *skb); > > void ieee802154_xmit_sync_worker(struct work_struct *work); > > +void ieee802154_sync_tx(struct ieee802154_local *local); > > netdev_tx_t > > ieee802154_monitor_start_xmit(struct sk_buff *skb, struct net_device *dev); > > netdev_tx_t > > diff --git a/net/mac802154/tx.c b/net/mac802154/tx.c > > index de5ecda80472..d1fd2cc67cbe 100644 > > --- a/net/mac802154/tx.c > > +++ b/net/mac802154/tx.c > > @@ -48,6 +48,7 @@ void ieee802154_xmit_sync_worker(struct work_struct *work) > > > > kfree_skb(skb); > > atomic_dec(&local->phy->ongoing_txs); > > + wake_up(&local->phy->sync_txq); > > if (atomic_dec_and_test(&hw->phy->ongoing_txs)) > wake_up(&hw->phy->sync_txq); As we test this condition in the waiting path I assumed it was fine to do it this way, but the additional check does not hurt, so I'll add it. Thanks, Miquèl
