Hi Jakub, kuba@xxxxxxxxxx wrote on Tue, 4 Jan 2022 07:01:27 -0800: > On Tue, 4 Jan 2022 15:41:51 +0100 Miquel Raynal wrote: > > > On Wed, 22 Dec 2021 16:57:33 +0100 Miquel Raynal wrote: > > > > +/* Maximum number of PAN entries to store */ > > > > +static int max_pan_entries = 100; > > > > +module_param(max_pan_entries, uint, 0644); > > > > +MODULE_PARM_DESC(max_pan_entries, > > > > + "Maximum number of PANs to discover per scan (default is 100)"); > > > > + > > > > +static int pan_expiration = 60; > > > > +module_param(pan_expiration, uint, 0644); > > > > +MODULE_PARM_DESC(pan_expiration, > > > > + "Expiration of the scan validity in seconds (default is 60s)"); > > > > > > Can these be per-device control knobs? Module params are rarely the > > > best answer. > > > > I believe we can do that on a per FFD device basis (for now it will be > > on a per-device basis, but later when we will have the necessary > > information we might do something more fine grained). Would a couple of > > sysfs entries work? > > Is there no netlink object where this would fit? Sorry, I'm not at all > familiar with WPAN. If it's orthogonal to current cfg802154 objects > sysfs is fine, I guess. Yes it's definitely possible to add a netlink arg for these two parameters as well. Thanks, Miquèl
