Re: [PATCH v2] net: ieee802154: fix shift-out-of-bound in nl802154_new_interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 12, 2021 at 11:12 AM Alexander Aring <alex.aring@xxxxxxxxx> wrote:
>
> Hi,
>
> On Thu, 11 Nov 2021 at 09:59, Dongliang Mu <mudongliangabcd@xxxxxxxxx> wrote:
> >
> > In nl802154_new_interface, if type retrieved from info->attr is
> > NL802154_IFTYPE_UNSPEC(-1), i.e., less than NL802154_IFTYPE_MAX,
> > it will trigger a shift-out-of-bound bug in BIT(type) [1].
> >
> > Fix this by adding a condition to check if the variable type is
> > larger than NL802154_IFTYPE_UNSPEC(-1).
> >
>
> Thanks.
>
> I just sent another patch to fix this issue. The real problem here is
> that the enum type doesn't fit into the u32 netlink range as I
> mentioned some months ago. [0] Sorry for the delayed fix.

It's fine. This fix hits the core of the underlying bug.

>
> - Alex
>
> [0] https://lore.kernel.org/linux-wpan/CAB_54W62WZCcPintGnu-kqzCmgAH7EsJxP9oaeD2NVZ03e_2Wg@xxxxxxxxxxxxxx/T/#t



[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux